Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move schema and watch to internal #2949

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Oct 2, 2024

Moving some packages as they will be used by the external go plugin, such that go-runtime should not use anything in backend, and vice versa:

  • backend/schema -> internal/schema
  • internal/buildengine's discovery and file watching features -> internal/watch

@ftl-robot ftl-robot mentioned this pull request Oct 2, 2024
@matt2e matt2e force-pushed the matt2e/plugin-move-packages branch 4 times, most recently from 1c22b64 to 7f971c1 Compare October 2, 2024 04:31
@matt2e matt2e marked this pull request as ready for review October 2, 2024 04:42
@matt2e matt2e requested review from a team and alecthomas as code owners October 2, 2024 04:42
@matt2e matt2e requested review from a team and wesbillman and removed request for a team October 2, 2024 04:42
@matt2e matt2e force-pushed the matt2e/plugin-move-packages branch from 57febd9 to 10003ef Compare October 2, 2024 05:36
@matt2e matt2e force-pushed the matt2e/plugin-move-packages branch from 10003ef to 6b1ebb6 Compare October 2, 2024 05:37
@matt2e matt2e merged commit 9479c62 into main Oct 2, 2024
93 checks passed
@matt2e matt2e deleted the matt2e/plugin-move-packages branch October 2, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants